Skip to content

improvement(kb-connectors): align connector UI surfaces#4728

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/kb-connector-design-review
May 22, 2026
Merged

improvement(kb-connectors): align connector UI surfaces#4728
waleedlatif1 merged 1 commit into
stagingfrom
codex/kb-connector-design-review

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

@waleedlatif1 waleedlatif1 commented May 22, 2026

Summary

  • refreshed knowledge base connector cards, modals, selectors, document actions, and connector indicators to align with the platform direction
  • tightened connector-adjacent list/card/header states and updated the Mothership footer docs link

Type of Change

  • Improvement

Testing

  • bun run lint
  • bun run check:api-validation:strict
  • cd apps/sim && bun run lint:check
  • cd apps/sim && bun run type-check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 22, 2026 8:10pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 22, 2026 •
edited
Loading

PR Summary

Low Risk
Primarily UI/styling adjustments to connector-related components with minor behavior tweaks (e.g., useId for checkbox association and combobox empty states), so functional risk is low.

Overview
Refreshes the knowledge base connectors UI to match updated surface/interaction patterns across the connectors list, connector badges, add/edit connector modals, selector fields, and sync history, including clearer status/disabled indicators and more consistent button/empty/loading states.

Also limits connector icon stacks in knowledge base cards and the knowledge base list to the first 3 with a +N overflow tooltip, and updates the landing footer Mothership docs link to https://docs.sim.ai/mothership.

Reviewed by Cursor Bugbot for commit ffd4bb9. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 22, 2026 •
edited
Loading

Greptile Summary

This PR refreshes the knowledge base connector UI surfaces — cards, modals, selectors, and status indicators — to align with the platform's design direction, replacing raw <button> elements with the Button component, adopting consistent design tokens, and adding connector overflow handling (capping visible icons at 3 with a +N tooltip).

  • Connector indicator chips in base.tsx gain per-status dot overlays (error/disabled/other), a max-w-[180px] truncation cap, and switch from a plain <button> to the Button component.
  • ConnectorsSection now accepts a className prop, uses useId() for the delete-docs checkbox (preventing ID collisions), and replaces hardcoded amber color tokens with design-system variables (--caution, --success).
  • BaseCard and knowledge.tsx both cap the connector icon stack at 3 visible entries with a memoized +N overflow badge showing a tooltip of hidden connector names.

Confidence Score: 5/5

All changes are UI-only styling and component refactors with no logic mutations — safe to merge.

Every changed file touches only visual presentation: replacing native buttons with the Button component, swapping hardcoded color values for design tokens, adding overflow badges for connector icons, and a single docs URL update. There are no data mutations, no API contract changes, and no conditional logic alterations that could introduce regressions.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx Replaces native button with Button component for connector indicator chips; adds per-status dot overlay using design tokens; passes className='mt-0' to ConnectorsSection inside modal.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.tsx Adds className prop, useId() for delete-docs checkbox, CONNECTOR_ACTION_BUTTON_CLASSES constant, design-token color swaps (amber→caution/success), and layout/spacing refinements throughout ConnectorCard and SyncHistory.
apps/sim/app/workspace/[workspaceId]/knowledge/components/base-card/base-card.tsx Adds useMemo for connector-derived arrays (addressed from previous thread), caps visible icons at 3 with a +N overflow tooltip badge, and updates connector icon container styling.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsx Refines search bar, ConnectorTypeCard layout, and tag definitions container; replaces native button elements with Button component; removes inline section comments.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/edit-connector-modal/edit-connector-modal.tsx Mirrors add-connector-modal Button upgrades; improves DocumentsTab skeleton, document list hover states, and wraps external-link icon in a tooltip.
apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx connectorCell now caps visible entries at 3 with a +N overflow badge (tooltip lists hidden connector names) and updates icon container styling to match card view.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/connector-selector-field/connector-selector-field.tsx Adds size='sm' and emptyMessage prop to both single and multi-select Combobox instances; switches loading state from text-sm to text-caption.
apps/sim/app/(landing)/components/footer/footer.tsx Updates Mothership footer link from the root docs URL to the /mothership subpath.

Reviews (2): Last reviewed commit: "improvement(kb-connectors): align connec..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed May 22, 2026
View reviewed changes
Comment thread apps/sim/app/workspace/[workspaceId]/knowledge/components/base-card/base-card.tsx Outdated
@waleedlatif1 waleedlatif1 force-pushed the codex/kb-connector-design-review branch from 20db253 to ffd4bb9 Compare May 22, 2026 20:10
@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

waleedlatif1 commented May 22, 2026

@greptile

@waleedlatif1
Copy link
Copy Markdown
Collaborator Author

waleedlatif1 commented May 22, 2026

@cursor review

cursor[bot]
cursor Bot reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit ffd4bb9. Configure here.

@waleedlatif1 waleedlatif1 merged commit 5c19344 into staging May 22, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the codex/kb-connector-design-review branch May 22, 2026 22:39
@waleedlatif1 waleedlatif1 mentioned this pull request May 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1